I far prefer the straight stock. They are hard to find though, at least around South Florida. I have been looking for some time, for a straight stock trigger guard plate, so I can convert my 336Y from the pistol grip to a straight grip.
Until I learn better, I like the straight grip best. My Winchester 1892 is just perfect with the straight grip and the crescent butt. I shoot a rifle well if it has that RIGHT FEEL. My 1897T also is a good fit for me with the straight grip but flat butt. Close behind my beloved Win 1892 is my Marlin 1881 straight grip.
Now I just got a Marlin 336 with that kind of ugly pistol grip, took it to the silhouette match last Saturday and shot a 33/40 which included 10 straight turkeys, much better than I anticipated I'd do with a 20" carbine! So maybe a pistol grip isn't so bad after all.
My favorite pistol grip of all at least for looks are those on the older Marlins that have the S shape to them on the bottom side. Those look very CLASSIC, but I've never been around one of them to shoulder one and see how she feels. Long winded but it is a good question!